Make sure to use timeString/timeStringNullable everywhere for SQLite - #1353
Merged
Conversation
Make sure to use `timeString`/`timeStringNullable` everywhere for SQLite rather than passing a `time.Time` or `*time.Time`. Using the latter works, but causes the underlying driver to default to whatever serialization method for the time it wants to use, making it a different format compared to what we normally store, and leading to requiring liberal input unmarshaling as times might exist in a variety of formats (we had a recent River Pro bug where this was the case). I also checked River Pro for problems of this sort, but we're clean over there already.
brandur
force-pushed
the
brandur-time-string
branch
from
August 20, 2026 21:50
6b73c82 to
2c7ccfc
Compare
bgentry
approved these changes
Aug 21, 2026
Contributor
Author
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to use
timeString/timeStringNullableeverywhere for SQLiterather than passing a
time.Timeor*time.Time. Using the latterworks, but causes the underlying driver to default to whatever
serialization method for the time it wants to use, making it a different
format compared to what we normally store, and leading to requiring
liberal input unmarshaling as times might exist in a variety of formats
(we had a recent River Pro bug where this was the case).
I also checked River Pro for problems of this sort, but we're clean over
there already.